-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple project folders #16
Conversation
* `[email protected]` was a dependency of the `vscode` package and was pulled from NPM * The `vscode` package was deprecated anyway and replaced with `@types/vscode`
Resolves thadeu#15 Iterate over workspace folders to find the project folder that matches the active file. Use this project folder to determine the root path.
First, thanks for sharing your experience, and helping with the Pull Request. I did some testing, and the changes impact some scenarios. To make it easier, I will take advantage of your idea and make the necessary changes to support multiple workspaces. I will do it as soon as possible, in the meantime, your PR will be open for further discussion. Thanks for everything. |
Thanks, @thadeu. Please reach out if I can help in anyway. 👍🏼 |
I'm also interested in this feature. Is there anything I can do to help fix those scenarios? |
@thadeu Thanks for this amazing extension, I use it extensively and it has helped me a lot. I'm currently having this issue, is there any update on solving it? I could help if you don't have time atm, just let me know what are the scenarios that this PR is not covering. |
@gulazaro94 @martinzamuner @yock I'm so excited in order to allow this feature, but I didnt finish test locally. So, I'll testing weekend and I'll create a new release with this feature coming soon. Thanks for all for helping to improvement! |
any update @thadeu ? |
Also chiming in here that I'm grateful for this extension, but for many projects can't use it due to the lack of this feature. What can we do to help? Happy to put some time on the calendar to pair! |
Hey guys! I'm sorry for keep in cold this PR. I'm checking right now and next going to send to markeplace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@yock @bbuchalter @domenico-angilletta v0.5.10 is live! Thanks for all |
@thadeu
When utilizing multiple project folders in a workspace the extension implicitly assumes that the active file will be located in the first project in the workspace. When it is not the
rspec
command will not include the path to the spec file (see issue #15). This PR also updates the project's TypeScript and VSCode dependencies to resolve a couple of vulnerabilities and deprecations for extension maintainers.This extension is a big part of my everyday work. I'm grateful for the effort that you have put into it.