Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple project folders #16

Merged
merged 4 commits into from
May 25, 2022

Conversation

yock
Copy link
Contributor

@yock yock commented Jan 28, 2021

@thadeu

When utilizing multiple project folders in a workspace the extension implicitly assumes that the active file will be located in the first project in the workspace. When it is not the rspec command will not include the path to the spec file (see issue #15). This PR also updates the project's TypeScript and VSCode dependencies to resolve a couple of vulnerabilities and deprecations for extension maintainers.

This extension is a big part of my everyday work. I'm grateful for the effort that you have put into it.

* `[email protected]` was a dependency of the `vscode` package and was pulled from NPM
* The `vscode` package was deprecated anyway and replaced with `@types/vscode`
Resolves thadeu#15

Iterate over workspace folders to find the project folder that matches the active file. Use this project folder to determine the root path.
@thadeu
Copy link
Owner

thadeu commented Jan 29, 2021

@yock

First, thanks for sharing your experience, and helping with the Pull Request. I did some testing, and the changes impact some scenarios. To make it easier, I will take advantage of your idea and make the necessary changes to support multiple workspaces.

I will do it as soon as possible, in the meantime, your PR will be open for further discussion.

Thanks for everything.

@thadeu thadeu added the enhancement New feature or request label Jan 29, 2021
@yock
Copy link
Contributor Author

yock commented Jan 29, 2021

Thanks, @thadeu. Please reach out if I can help in anyway. 👍🏼

@martinzamuner
Copy link

I'm also interested in this feature. Is there anything I can do to help fix those scenarios?

@gulazaro94
Copy link

@thadeu Thanks for this amazing extension, I use it extensively and it has helped me a lot.

I'm currently having this issue, is there any update on solving it? I could help if you don't have time atm, just let me know what are the scenarios that this PR is not covering.

@thadeu
Copy link
Owner

thadeu commented Dec 1, 2021

@gulazaro94 @martinzamuner @yock

I'm so excited in order to allow this feature, but I didnt finish test locally.

So, I'll testing weekend and I'll create a new release with this feature coming soon.

Thanks for all for helping to improvement!

@domenico-angilletta
Copy link

any update @thadeu ?

@bbuchalter
Copy link

Also chiming in here that I'm grateful for this extension, but for many projects can't use it due to the lack of this feature. What can we do to help? Happy to put some time on the calendar to pair!

@thadeu
Copy link
Owner

thadeu commented May 25, 2022

Hey guys! I'm sorry for keep in cold this PR. I'm checking right now and next going to send to markeplace.

Copy link
Owner

@thadeu thadeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thadeu thadeu merged commit 6a5b5e0 into thadeu:master May 25, 2022
@thadeu
Copy link
Owner

thadeu commented May 25, 2022

@yock @bbuchalter @domenico-angilletta v0.5.10 is live!

Thanks for all

@yock yock deleted the fix/multiple-project-folders branch May 25, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants