quran#341 twitter and facebook, minor style tweak

thabti · Jul 2, 2016 · 39cb413 · 39cb413
1 parent f326f90
commit 39cb413
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -1,6 +1,5 @@
 {
   "parser": "babel-eslint",
-  "extends": "airbnb",
   "env": {
     "browser": true,
     "node": true,
@@ -14,13 +13,13 @@
     "import/named": 0,
     "import/namespace": 0,
     "import/no-unresolved": 0,
-    "import/no-named-as-default": 2,
+    "import/no-named-as-default": 0,
     // Temporarirly disabled due to a possible bug in babel-eslint (todomvc example)
     "block-scoped-var": 0,
     // Temporarily disabled for test/* until babel/babel-eslint#33 is resolved
     "padded-blocks": 0,
     "comma-dangle": 0,  // not sure why airbnb turned this on. gross!
-    "indent": [2, 2, {"SwitchCase": 1}],
+    "indent": [0, 0, {"SwitchCase": 1}],
     "no-console": 0,
     "no-alert": 0,
     "object-curly-spacing": 0,

diff --git a/src/components/Share/index.js b/src/components/Share/index.js
@@ -12,8 +12,8 @@ export default class Share extends Component {
 
     return (
       <div className={Style.share}>
-        <i onClick={()=> this.onClickPopup(facebookUl, "Facebook")} className={Style.facebook} data-metrics-event-name="Share:Facebook"></i>
-        <i onClick={()=> this.onClickPopup(twitterUrl, "Twitter")} className={Style.twitter} data-metrics-event-name="Share:Twitter"></i>
+        <i onClick={()=> this.onClickPopup(facebookUl, "Facebook")} className={Style.facebook} data-metrics-event-name="Share:Facebook" title="Share on Facebook"></i>
+        <i onClick={()=> this.onClickPopup(twitterUrl, "Twitter")} className={Style.twitter} data-metrics-event-name="Share:Twitter" title="Share on Twitter"></i>
       </div>
     )
   }

diff --git a/src/components/Share/style.scss b/src/components/Share/style.scss
@@ -1,13 +1,14 @@
 .share {
   position: relative;
-  bottom: 5px;
-  left: 10px;
+  bottom: 2px;
+  left: 5px;
 }
 
 .facebook {
   background-image: url(../../../static/images/FB-grn.png);
   background-repeat: no-repeat;
   padding-right: 30px;
+  background-size: 12px;
   padding-bottom: 10px;
   padding-top: 1px;
 
@@ -20,6 +21,7 @@
   background-image: url(../../../static/images/Twitter-grn.png);
   background-repeat: no-repeat;
   padding-right: 30px;
+  background-size: 21px;
   padding-bottom: 10px;
 
   &:hover {