Don't log test initial test daemon ping failures

This is just noise due to timing. I picked `> 2` just based on logs from tests I've seen there's always 1 or 2. Signed-off-by: Brian Goff <[email protected]>
thaJeztah · Jul 12, 2019 · 15675e2 · 15675e2
1 parent c7d1908
commit 15675e2
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/internal/test/daemon/daemon.go b/internal/test/daemon/daemon.go
@@ -311,7 +311,7 @@ func (d *Daemon) StartWithLogFile(out *os.File, providedArgs ...string) error {
 	defer cancel()
 
 	// make sure daemon is ready to receive requests
-	for {
+	for i := 0; ; i++ {
 		d.log.Logf("[%s] waiting for daemon to start", d.id)
 
 		select {
@@ -325,9 +325,14 @@ func (d *Daemon) StartWithLogFile(out *os.File, providedArgs ...string) error {
 
 			resp, err := client.Do(req.WithContext(rctx))
 			if err != nil {
-				d.log.Logf("[%s] error pinging daemon on start: %v", d.id, err)
-
-				time.Sleep(500 * time.Millisecond)
+				if i > 2 { // don't log the first couple, this ends up just being noise
+					d.log.Logf("[%s] error pinging daemon on start: %v", d.id, err)
+				}
+
+				select {
+				case <-ctx.Done():
+				case <-time.After(500 * time.Microsecond):
+				}
 				continue
 			}