Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added font coloring to GoalForm > GoalInput #815

Merged
merged 3 commits into from
May 23, 2024
Merged

Added font coloring to GoalForm > GoalInput #815

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7838962
Added font coloring to GoalForm > GoalInput
alvarotorrestx May 20, 2024
487399b
added color to goal submit button
alvarotorrestx May 20, 2024
8d2017a
Redesigned input and button on dashboard > goals using styled component
alvarotorrestx May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/components/Dashboard/OldDashbaord/GoalSetter/GoalForm.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ const GoalInput = styled.input`
border-radius: 5px;
margin-bottom: 10px;
font-family: inherit;
color: #1c1c1c;
`;

const GoalForm = () => {
Expand Down Expand Up @@ -46,7 +47,10 @@ const GoalForm = () => {
onChange={(e) => setText(e.target.value)}
placeholder="What's your goal?"
/>
<button className={"btn btn-block"} type={"submit"}>
<button
className={"btn btn-block !bg-[#ff6b08] !text-[#1c1c1c] hover:opacity-[.95]"}
type={"submit"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the project we are using styled component, if you already made a change to this button maybe refactor it into using the styled component library?

What do you say ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, right

but issue is this goal app is just mixuture of styled .css tailwinds

anyway, we are replacing this one with task app in future

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I apologize. I’ll update using the styled component today and will submit with screenshot.

Do you want the input bar to be restyled to match your color scheme such as the input on notes portion of dashboard?

The button is also orange on those portion of the app.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I apologize. I’ll update using the styled component today and will submit with screenshot.

Do you want the input bar to be restyled to match your color scheme such as the input on notes portion of dashboard?

The button is also orange on those portion of the app.

u can improve the design in any way,.

Do you want the input bar to be restyled to match your color scheme such as the input on notes portion of dashboard?

orange wil work, if it is looking good on styles

>
+
</button>
</div>
Expand Down