Bump rust-g to 0.8.0 #68673
Closed
Bump rust-g to 0.8.0 #68673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to tgstation/rust-g#101 (or tgstation/rust-g@76fd17a ), this version of rust-g makes Cellular Noise faster. We leverage the shit out of Cellular Noise in our cave generation across all maps (especially IceBoxStation), so I am very keen on seeing this. Here are some scuffed results from my local test on this claim, where you seem to see a not-bad 0.2 second reduction with the bumped DLL on my debug server: Might also be nice to use the other types of noise one day. One day. Also contains some more cargo crates or whatever you wanna call it. Cool.
|
i hate machines |
|
wait never mind this doesn't work because #67474 couldn't get through in time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
According to tgstation/rust-g#101 (or tgstation/rust-g@76fd17a ), this version of rust-g makes Cellular Noise faster. We leverage the shit out of Cellular Noise in our cave generation in pretty much every type of mining map (especially IceBoxStation), so I am very keen on seeing this.
Here are some scuffed results from my local test on this claim, where you seem to see a not-bad 0.2 second reduction with the bumped DLL on my debug server:
Might also be nice to use the other types of noise one day. One day. Also contains some more cargo crates or whatever you wanna call it. Cool.
This is the first time I've bumped a dependency so please let me know if I am forgetting something critically important.