fix shrike healing & crit healing and properly addresses regen delays #16607
Conversation
tgstation-server
added
Fix
|
The previous PR really should not have been fullmerged, but TM'd instead, but it's my fault since i didn't ask for it |
| @@ -84,22 +84,23 @@ | |||
|
|
|||
| /mob/living/carbon/xenomorph/proc/handle_critical_health_updates(seconds_per_tick) | |||
| if(loc_weeds_type) | |||
| heal_wounds(XENO_RESTING_HEAL, seconds_per_tick) | |||
| heal_wounds(XENO_RESTING_HEAL, seconds_per_tick = seconds_per_tick) // healing in critical while on weeds ignores scaling | |||
There was a problem hiding this comment.
to just absolutely make sure that it's very obvious what arg this is touching, preventing mistakes, if you don't want it i can remove it, comment doesn't mean i'm actually changing functionality in removing scaling, it already did that before, I'm just documenting it
There was a problem hiding this comment.
you can already see what its doing because its an arg, literally jut hover over and it will say.
There was a problem hiding this comment.
changed it to positional args as it seemed what was seemingly requested.
Anyway, to specify, heal_wounds has 3 args, multiplier, scaling, and now seconds_per_tick, I was using a named arg to bypass the scaling boolean, so it wouldn't erroniously give 2 to a boolean
About The Pull Request
Didn't realize heal_wounds was used in other places, this gives it a default arg of expected seco
Why It's Good For The Game
Fixes bad bugs and hopefully makes the revert PR not needed
Changelog
🆑
fix: shrike healing and crit healing should now work
add: regen delays now properly are handled by seconds_per_tick
/:cl: