Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyposprays/Autoinjectors now have 2 second injection delay on non-same faction injectees #16546

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

mrhugo13
Copy link
Contributor

@mrhugo13 mrhugo13 commented Sep 15, 2024

About The Pull Request

Added a check in the hypospray code that creates a 2 second delay on attempting to inject someone else who is not the same faction as you and alerting both the injectee and injector as to this occuring.
firefox_2024-09-27_07-46-43

Tested on a local client with zero (0) runtimes/errors
dreamseeker_2024-09-15_12-13-27

Made sincerily with imdedplzrestart energy.

Why It's Good For The Game

In any situation where HvH is involved, if one person has a peridaxon+ or qc/qc+ full hypospray set to inject on maximum they can just click on an enemy once in close range (use shield if you want to get close) and they will die in 10 seconds flat unless they already have extreme amounts of hypervene in their system. This fundamentally changes how HvH gamemodes work by having one person with a shield running around with hyposprays injecting people with OD levels of meds and almost instantly killing them, centering the balance all around them and how you can counter them essentially. Even when you have corpsmen with you they can take quite a while to fix you up from having insane amounts of toxins in your system and by the time you've gotten fixed up either the respawn timer allows you to get another body or the op/round is already over.

IM LOOKING AT YOU JEDD YES YOU I HAD TO DEAL WITH YOUR QC+/PERI+ HYPOSPRAY MEDRUSH STRAT YESTERDAY IN A CAMPAIGN ROUND I CONSISTENTLY DIED FROM YOUR ACTIONS AND ALTHOUGH I UNDERSTAND YOU WERE SIMPLY USING THE TOOLS YOU WERE GIVEN WITH AND THEREFOR WERE WITHIN THE MECHANICAL BOUNDARIES OF THE GAME I ABSOLUTELY HAVE NOT FELT MORE FRUSTRATION FROM ANY ONE SPECIFIC GAMEPLAY METHOD THANS YOURS CAN WE PLZ RESTART ROUND IMDED.

Changelog

🆑 Vondiech/Citruses
balance: Hyposprays and Autoinjectors now have a 2 second delay on trying to inject someone in a different faction than yours.
/:cl:

@tgstation-server tgstation-server added the Balance Changes to functionality that modifies how effective certain methods are at powergaming. label Sep 15, 2024
@Looking4bros
Copy link

Injectors used to have a Police or CQC skill check that stopped other people from being able to inject you, i think it disappeared in the reagents to chemistry changes.

@Naaanii
Copy link
Contributor

Naaanii commented Sep 16, 2024

The Waltuh nerf is so real

@AusarAtkin
Copy link
Contributor

AusarAtkin commented Sep 16, 2024

Injectors used to have a Police or CQC skill check that stopped other people from being able to inject you, i think it disappeared in the reagents to chemistry changes.

Lumi removed it in one of their HvH PRs about skills. #14512

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 3 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Pull request is awaiting delayed author response and may be closed. label Sep 24, 2024
@Lumipharon
Copy link
Contributor

this is some omega stinky copypaste code, and has no relevant checks or anything else

@mrhugo13
Copy link
Contributor Author

this is some omega stinky copypaste code, and has no relevant checks or anything else

CODE IMPROVED AND, ATLEAST IN ATTEMPT, MADE LESS STINKY (AFTER A CODE BATH)

@ivanmixo ivanmixo removed the Stale Pull request is awaiting delayed author response and may be closed. label Sep 30, 2024
Copy link
Contributor

@ivanmixo ivanmixo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lumipharon stop procrastinating

@Lumipharon Lumipharon merged commit b860cf0 into tgstation:master Oct 1, 2024
39 checks passed
github-actions bot added a commit that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Changes to functionality that modifies how effective certain methods are at powergaming.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants