Add functions for getting all sources used in Flowscript Compilation #87
Conversation
| /// <returns>True if imports could be resolved, false otherwise</returns> | ||
| public bool TryGetImports(List<string> files, out string[] resolvedImports) | ||
| { | ||
| CompilationUnit compilationUnit = new CompilationUnit(); |
There was a problem hiding this comment.
Would it be a lot of work to refactor to get rid of the dummy compilation unit (using just an array of Imports)?
Would be a bit cleaner that way.
There was a problem hiding this comment.
I'm not sure how hard it'd be but I'll give it a try.
This was definitely me being a bit lazy and just wanting something that worked quickly 😅
There was a problem hiding this comment.
Sorry not yet. I did a bit when you initially asked and realised it's going to be more work than I first thought. Nothing I can't do but I think it'll take a couple of hours which I just haven't found yet.
I'll try and do it this weekend so we can close this off.
There was a problem hiding this comment.
That wasn't too hard actually.
I've changed TryGetImports so it now uses a stripped down version of TryResolveImports which uses a list of Imports rather than a CompilationUnit.
It also now only parses flowscript files since they can contain additional imports whereas compiled bfs and messages can't so parsing the actual files is just a waste of time.
|
Thanks. Looks good. |
This PR adds two functions
TryGetImportsand aTryCompileWithImportsoverload that returns a list of all used source files as an out parameter.I intend to use both with BF Emulator/Persona Essentials so I can take into account changes in imports to flowscript files when caching compiled bf files.