selectively distinguish real serializers from mocked ones #1006 #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1011 +/- ##
=======================================
Coverage 98.54% 98.54%
=======================================
Files 68 68
Lines 8324 8324
=======================================
Hits 8203 8203
Misses 121 121
☔ View full report in Codecov by Sentry. |
This addresses an issue where we enter a code path that only works for real serializers, while the check also allows for objects covered by OpenApiSerializerExtension. However when checking for customized ListSerializers, we are only interested in actual serializers so distinguish the cases.
tfranzel
force-pushed
the
smart_list_serializer_check
branch
from
79f2646 to
5fe55a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue where we enter a code path that only works for real serializers, while the check also allows for objects covered by OpenApiSerializerExtension.
However when checking for customized ListSerializers, we are only interested in actual serializers so distinguish the cases.