Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting bug when generating schema, possible reason dj_rest_auth version 3.0.0 release leads to breaking changes #937

Closed
Danane84 opened this issue Feb 16, 2023 · 7 comments
Labels
bug Something isn't working fix confirmation pending issue has been fixed and confirmation from issue reporter is pending

Comments

@Danane84
Copy link

When I try to create a schema via the command python manage.py spectacular --file schema.yml I get the following error message:
ImportError: cannot import name 'JWTSerializer' from 'dj_rest_auth.app_settings'

I am using dj_rest_auth==3.0.0, which was released three days ago. I compared the dj_rest_auth.app_settings.py file of version 3.0.0 with the latest major version before that (version 2.2.8) and if I am not mistaken, JWTSerializer was indeed renamed to JWT_Serializer in the 3.0.0 version. So it seems to me that this variable name change in dj_rest_auth is causing an bug in drf-spectacular

If my assumption regarding the cause for the bug is correct, could you please fix it?

@Danane84 Danane84 changed the title Getting bug when generating schema, reason dj_rest_auth version 3.0.0 release leads to breaking changes Getting bug when generating schema, possible reason dj_rest_auth version 3.0.0 release leads to breaking changes Feb 16, 2023
@tfranzel tfranzel added the bug Something isn't working label Feb 16, 2023
@tfranzel
Copy link
Owner

Ahh, I see. They cleaned up their awkward setup in favor of something more idiomatic for DRF. nice! will have a fix soon.

@Danane84
Copy link
Author

thanks for your quick help, @tfranzel!

tfranzel added a commit that referenced this issue Feb 16, 2023
fix dj-rest-auth>=3.0.0 breaking changes #937
@tfranzel tfranzel added the fix confirmation pending issue has been fixed and confirmation from issue reporter is pending label Feb 16, 2023
@browser-bug
Copy link

browser-bug commented Feb 17, 2023

Thanks for this @tfranzel
Are you planning on releasing on PyPI soon?

@tfranzel
Copy link
Owner

yes. I'll want to look at another issue first but I plan in the next couple of days.

@mostaszewski
Copy link

@tfranzel I don't want to push you, but are you able to estimate when this fix will be released? Thank you!

@tfranzel
Copy link
Owner

tfranzel commented Mar 2, 2023

no worries. there were a couple of issues raised. currently working on a long pending feature. took longer than anticipated. end of week at the latest.

@tfranzel
Copy link
Owner

tfranzel commented Mar 4, 2023

closed with release 0.26.0

@tfranzel tfranzel closed this as completed Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix confirmation pending issue has been fixed and confirmation from issue reporter is pending
Projects
None yet
Development

No branches or pull requests

4 participants