Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show 'cargo-expand' errors when testing an exercise #60

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Yehuda-blip
Copy link

@Yehuda-blip Yehuda-blip commented Jul 13, 2024

Hey, I started going through the repo, It seems this is gonna be a great way for me to learn about macros!

When I tried to run the testing for the first exercise, the diff output was empty. I tried to deliberately fail the exercise but the diff was still empty, and I got a success result printed. Some debugging later it seems I skipped the "install cargo-expand" instruction in the readme. This PR just checks that the expand command ran successfully before printing results.

Steps to reproduce the problem:

  • uninstall cargo-expand
  • test exercise 1
    The diff should be empty, both when expecting success and both when expecting failure.

@alexanderankin
Copy link

potentially related to #59 ?

@Yehuda-blip
Copy link
Author

As far as I can tell, the issues are not related. In order to initially build the crate I followed the instructions in #59, (remove lock and build) - this solved the build issue. However, I did not have cargo-expand installed and this led to empty diffs with the run -- test command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants