Provide thisArg when calling apply. Fixes #1

tfoxy · Jun 15, 2015 · 935ef84 · 935ef84
1 parent 2151365
commit 935ef84
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/chrome-promise.js b/chrome-promise.js
@@ -27,7 +27,7 @@
     chrome = chrome || root.chrome;
     Promise = Promise || root.Promise;
 
-    var setPromiseFunction = function(val) {
+    var setPromiseFunction = function(fn, self) {
 
       return function() {
         var args = arguments;
@@ -44,7 +44,7 @@
           args[args.length] = callback;
           args.length++;
 
-          val.apply(null, args);
+          fn.apply(self, args);
         });
 
       };
@@ -62,7 +62,7 @@
             fillProperties(val, to[key]);
           }
           else if (type === 'function') {
-            to[key] = setPromiseFunction(val);
+            to[key] = setPromiseFunction(val, from);
           }
           else {
             to[key] = val;

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "chrome-promise",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "description": "Promises for chrome JavaScript APIs which is used in extensions and apps.",
   "main": "./index",
   "scripts": {