Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds test for KFC #75

Merged
merged 3 commits into from
Nov 21, 2023
Merged

adds test for KFC #75

merged 3 commits into from
Nov 21, 2023

Conversation

tfjgeorge
Copy link
Owner

@tfjgeorge tfjgeorge commented Nov 20, 2023

BUGFIX: KFAC for convolutions was scaled by the # of spatial positions but it should not.

actually the former implementation corresponds to what is derived in the KFC paper. However arguably the scaling by 1/S with S the number of spatial positions might not be optimal (see discussion in derivations/kfc.pdf) thus I instead scaled the test by S and reverted back to KFC expressions.

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d7225d9) 94.13% compared to head (ade2a1d) 94.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   94.13%   94.89%   +0.75%     
==========================================
  Files          31       31              
  Lines        3479     3464      -15     
==========================================
+ Hits         3275     3287      +12     
+ Misses        204      177      -27     
Flag Coverage Δ
unittests 94.89% <100.00%> (+0.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tfjgeorge tfjgeorge merged commit 5658a74 into master Nov 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant