Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk): add etf2l sdk #6

Merged
merged 10 commits into from
Nov 16, 2024
Merged

feat(sdk): add etf2l sdk #6

merged 10 commits into from
Nov 16, 2024

Conversation

TheBv
Copy link
Contributor

@TheBv TheBv commented Jan 19, 2023

Draft for the etf2l api sdk.
Currently only contains types, which could be improved/restructured a bit.

Rest will follow soon.

@c43721 c43721 added sdk Edits an SDK scope:library labels Jan 19, 2023
@TheBv
Copy link
Contributor Author

TheBv commented Mar 25, 2023

Blocked due to the query params in the v2 API just not working at all.

@c43721 c43721 changed the title feat(sdk,lib): add etf2l feat(sdk): add etf2l sdk Nov 2, 2024
@github-actions github-actions bot removed the sdk Edits an SDK label Nov 8, 2024
@github-actions github-actions bot added the logstf logs.tf sdk label Nov 8, 2024
@c43721 c43721 added sdk Edits an SDK etf2l etf2l sdk and removed logstf logs.tf sdk labels Nov 8, 2024
@github-actions github-actions bot added logstf logs.tf sdk and removed sdk Edits an SDK labels Nov 14, 2024
@TheBv
feat: added tests
7f84ffb 
added ban types
@TheBv TheBv marked this pull request as ready for review November 15, 2024 00:33
c43721
c43721 requested changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@c43721 c43721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to get docs created

javascript-sdk/etf2l/types/player/playerTransferTeam.ts Outdated Show resolved Hide resolved
javascript-sdk/etf2l/api/etf2l.ts Outdated Show resolved Hide resolved
javascript-sdk/etf2l/api/etf2l.ts Show resolved Hide resolved
c43721
c43721 requested changes Nov 15, 2024
View reviewed changes
.vscode/launch.json Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
javascript-sdk/etf2l/mod.ts Outdated Show resolved Hide resolved
javascript-sdk/etf2l/types/team/teamCompetition.ts Show resolved Hide resolved
@c43721 c43721 merged commit 34bc0ad into tf2-software-enthusiasts:main Nov 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c43721 c43721 c43721 requested changes

Assignees

@TheBv TheBv

Labels
etf2l etf2l sdk logstf logs.tf sdk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheBv @c43721