-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #13
Update dependencies #13
Conversation
The tests are not passing locally. I get
|
const rule = require("../src/textlint-rule-date-weekday-mismatch"); | ||
const dateWeekdayMismatchRule = require("../src/textlint-rule-date-weekday-mismatch"); | ||
const rule = { | ||
rules: [{ | ||
ruleId: "date-weekday-mismatch", | ||
rule: dateWeekdayMismatchRule, | ||
options: { | ||
lang: "ja" | ||
} | ||
}] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a problem with passing the rule
as is?
Most test cases test if no options = automatic determination works well..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const rule = {...}
is for multiple rules or plugin combination.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After updating the dependencies, the tests failed:
+ '2016年12月29日(月)'
- '2016年12月29日(木)'
^
+ expected - actual
-2016年12月29日(月)
+2016年12月29日(木)
I assumed this was due to needing the language set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
English also failing:
+ actual - expected
+ '2021-07-02 (Thursday)'
- '2021-07-02 (Friday)'
This error is occured when rule's options is conflict.
vs.
textlint-tester can not override |
The readme on https://github.com/textlint-rule/textlint-rule-date-weekday-mismatch lists Japanese as |
https://github.com/wanasit/chrono/releases/tag/v2.0.2
chrono v2 seems to have lost the automatic language determination feature. |
I think it is intentionally vague. But I don't remember why. |
OK ... so // src/textlint-rule-date-weekday-mismatch.js:67
const text = "2016年12月29日(月)"
const chronoDates = chrono.parse(text);
// []
const chronoDates = chrono['ja'].parse(text);
// 0: ParsingResult {text: '2016年12月29日' …} |
Closing. Stale. |
This PR updates package and workflow dependencies.
Fixes #2
Fixes Dependabot CVE-2021-23371