match uppercase non-english letters too #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sentence-splitter ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
azu
reviewed
Nov 6, 2023
There was a problem hiding this comment.
Thanks!
Can you add some test case?
https://github.com/textlint-rule/sentence-splitter#adding-snapshot-testcase
src/parser/AbbrMarker.ts
Outdated
| @@ -7,7 +7,7 @@ const isCapitalized = (text: string) => { | |||
| if (!text || text.length === 0) { | |||
| return false; | |||
| } | |||
| return /^[A-Z]/.test(text); | |||
| return /^\p{Lu}/u.test(text); | |||
There was a problem hiding this comment.
📝 Node.js 10+ has supported Unicode character class escape: \p{...}, \P{...} - JavaScript | MDN.
There was a problem hiding this comment.
I prefer to use /^\p{Uppercase_Letter}/ because I needed to find out what Lu meant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#44