Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daily evaluated billing, monthly invoicing #408

Merged
merged 7 commits into from
Nov 17, 2020
Merged

Conversation

sanderpick
Copy link
Member

Adds a daily evaluation mechanism and a number of simplifications to the API.

@sanderpick sanderpick self-assigned this Nov 17, 2020
Copy link
Contributor

@jsign jsign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left some important comment regarding a particular function to double-check. 👍🏼

api/billingd/pb/billingd.proto Show resolved Hide resolved
api/billingd/service/service.go Show resolved Hide resolved
api/billingd/service/service.go Outdated Show resolved Hide resolved
api/billingd/service/service.go Outdated Show resolved Hide resolved
@sanderpick sanderpick merged commit 3d5f753 into master Nov 17, 2020
@sanderpick sanderpick deleted the sander/daily-billing branch November 17, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants