-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Archive storage config API #361
Conversation
Signed-off-by: Aaron Sutula <[email protected]>
Signed-off-by: Aaron Sutula <[email protected]>
…ive-config Signed-off-by: Aaron Sutula <[email protected]>
Signed-off-by: Aaron Sutula <[email protected]>
…ive-config Signed-off-by: Aaron Sutula <[email protected]>
Ok getting a legit error in the integration test
@jsign just checking if there is something we need to change about the lotus devnet and/or powergate setup in here? Anything come to mind? |
Updated the compose file to powergate 0.6.6 and lotus-devnet sha-35afaa3 and now the error is:
|
Yes, most probably is related to forcing Peter's miners in the version of Powergate you've updated. Now that in v0.6.6 we switched to SR2 miner selector by default, might make sense again to have the original StorageConfig which doesn't have a replication factor of 5, which is my best guess about that error.
I can confirm this theory on Monday, but makes sense to me. |
Thanks @jsign. That gives me a path forward. Will dig in more later. |
Signed-off-by: Aaron Sutula <[email protected]>
Signed-off-by: Aaron Sutula <[email protected]>
Signed-off-by: Aaron Sutula <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I left some questions in the wild.
Signed-off-by: Aaron Sutula <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I left a bunch of nits, but otherwise looks solid.
Signed-off-by: Aaron Sutula <[email protected]>
Signed-off-by: Aaron Sutula <[email protected]>
Signed-off-by: Aaron Sutula <[email protected]>
Signed-off-by: Aaron Sutula <[email protected]>
Signed-off-by: Aaron Sutula <[email protected]>
Allows getting and setting the default
ArchiveConfig
perBucket
and allows you to pass an overrideArchiveConfig
with each call toArchive
.Updates everything from mongo, rpc, client, local buckets api, and cli.
closes #336
closes #339