[SPIR-V] add SPV_EXT_mesh_shader to opt allowlist (microsoft#6224)

Bring SPIRV-Tools changes required to optimize code using this extension. Fixes microsoft#6087 Signed-off-by: Nathan Gauër <[email protected]>
tex3d · Jan 30, 2024 · 2fae54a · 2fae54a
1 parent fadd627
commit 2fae54a
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 2 deletions.
diff --git a/external/SPIRV-Headers b/external/SPIRV-Headers
diff --git a/external/SPIRV-Tools b/external/SPIRV-Tools
diff --git a/tools/clang/test/CodeGenSPIRV/meshshading.ext.optimized.hlsl b/tools/clang/test/CodeGenSPIRV/meshshading.ext.optimized.hlsl
@@ -0,0 +1,23 @@
+// RUN: %dxc -T ms_6_6 -E main -spirv -fspv-target-env=vulkan1.3 %s | FileCheck %s
+
+// CHECK:      OpExtension "SPV_EXT_mesh_shader"
+
+struct Object
+{
+    float4 v: SV_POSITION;
+};
+
+RWStructuredBuffer<int> buffer;
+
+// If optimizations are disabled, this function is not inlined.
+// This means a RWStructuredBuffer will be created as a local variable,
+// which is impossible in logical SPIR-V.
+// Hence why should make sure the optimizations are enabled for mesh shaders.
+void foo(RWStructuredBuffer<int> param) { }
+
+[outputtopology("triangle")]
+[numthreads(1, 1, 1)]
+void main(out indices uint3 idx[3], out vertices Object vtx[3])
+{
+  foo(buffer);
+}
+78 −0		LICENSE
+5 −0		include/spirv/unified1/spirv.bf
+42 −0		include/spirv/unified1/spirv.core.grammar.json
+5 −0		include/spirv/unified1/spirv.cs
+7 −0		include/spirv/unified1/spirv.h
+7 −0		include/spirv/unified1/spirv.hpp
+7 −0		include/spirv/unified1/spirv.hpp11
+5 −0		include/spirv/unified1/spirv.json
+5 −0		include/spirv/unified1/spirv.lua
+5 −0		include/spirv/unified1/spirv.py
+5 −0		include/spirv/unified1/spv.d
+24 −23		tools/buildHeaders/header.cpp
+2 −2		.github/workflows/scorecard.yml
+3 −3		DEPS
+2 −0		source/opcode.cpp
+1 −0		source/opt/aggressive_dead_code_elim_pass.cpp
+2 −2		source/opt/local_access_chain_convert_pass.cpp
+1 −0		source/opt/local_single_block_elim_pass.cpp
+1 −0		source/opt/local_single_store_elim_pass.cpp
+2 −0		source/opt/optimizer.cpp
+12 −0		source/val/validate_mode_setting.cpp
+8 −3		source/val/validate_non_uniform.cpp
+6 −2		source/val/validate_scopes.cpp
+11 −10		test/CMakeLists.txt
+178 −0		test/val/val_modes_test.cpp
+22 −2		test/val/val_non_uniform_test.cpp
+10 −0		tools/opt/opt.cpp
+3 −0		tools/sva/src/spirv.data.js