Fixed mmap on OpenBSD #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there no way to allocate huge pages on OpenBSD? |
|
I dont think so. Edit: I have found these by trying to compile the latest monerod on OpenBSD. |
|
Perhaps the best solution would be this: #elif defined(__OpenBSD__)
mem = MAP_FAILED; //hugepages not supportedLike this, the allocator would not lie about having successfully allocated large pages. In monerod, it would automatically fall back to the C++ allocator (and show a warning). |
|
Sounds good. I will test this with monero. |
OpenBSD's mmap does not support `MAP_HUGETLB` and `MAP_POPULATE`.
ston1th
force-pushed
the
fix_openbsd_mmap
branch
from
1d1adfd
to
f3ded36
Compare
|
Compilation and tests of monero are successful. |
ston1th
added a commit
to ston1th/monero
that referenced
this pull request
Oct 20, 2019
Added the `RANDOMX_FLAG_SECURE` for the JIT on OpenBSD. For a successful build on OpenBSD PR tevador/RandomX#139 needs to be merged and imported into the monero tree. Cleaned up build instructions.
tevador
approved these changes
Oct 20, 2019
SChernykh
approved these changes
Oct 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenBSD's mmap does not support
MAP_HUGETLBandMAP_POPULATE.