-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Emscripten version 3.1.57 #2290
Add support for Emscripten version 3.1.57 #2290
Conversation
6cb2228
to
f3c7add
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the backward incompatibility introduced by Emscripten, so I would prefer just remove the old names - the only promise we make is the API of our public Go package stability and this is different. in other words, this could potentially accumulate overtime and we have to remove the tech debt at some point future vs now
@mathetake that would also be fine, but that does mean that any wasm file compiled with Emscripten < 3.1.57 will suddenly stop working after upgrading Wazero without a clear indication why. |
yeah, that's unfortunate but as long as we put that in the release note, this should be good |
Signed-off-by: Jeroen Bobbeldijk <[email protected]>
8354940
to
522d7b4
Compare
@mathetake I have removed the backwards compatible code. Can you tell me how you compile the .wat files? When I use wabt I get a different output, but perhaps that has to do with wabt options and/or version. |
Signed-off-by: Takeshi Yoneda <[email protected]>
pushed the fix! |
Emscripten has removed some exported functions and replaced them with pure JS functions. They still reference native methods though, they just have a different name and the JS method is just an alias for the native function.
This PR adds the ability to add function aliases for exported Emscripten functions, since Emscripten renamed some exports on their side, see emscripten-core/emscripten#21555
This change is backwards compatible.