Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regalloc: eliminates unnecessary Instr loop #2258

Merged
merged 1 commit into from
Jun 18, 2024
Merged

regalloc: eliminates unnecessary Instr loop #2258

merged 1 commit into from
Jun 18, 2024

Conversation

mathetake
Copy link
Member

@mathetake mathetake commented Jun 18, 2024

This eliminates the unnecessary Instructions loop in
register allocation by sacrificing an almost negligible
memory space. As a result, overall compilation gets
1% faster than before.

goos: darwin
goarch: arm64
pkg: github.com/tetratelabs/wazero
                      │  old.txt   │             new.txt              │
                      │   sec/op   │   sec/op    vs base              │
Compilation/wazero-10   1.973 ± 1%   1.945 ± 0%  -1.42% (p=0.002 n=6)
Compilation/zig-10      4.128 ± 0%   4.068 ± 1%  -1.45% (p=0.002 n=6)
Compilation/zz-10       18.32 ± 0%   18.08 ± 1%  -1.27% (p=0.002 n=6)
geomean                 5.303        5.230       -1.38%

                      │   old.txt    │              new.txt               │
                      │     B/op     │     B/op      vs base              │
Compilation/wazero-10   284.4Mi ± 0%   284.8Mi ± 0%  +0.13% (p=0.002 n=6)
Compilation/zig-10      590.1Mi ± 0%   593.3Mi ± 0%  +0.55% (p=0.002 n=6)
Compilation/zz-10       536.4Mi ± 0%   536.8Mi ± 0%  +0.06% (p=0.002 n=6)
geomean                 448.2Mi        449.3Mi       +0.25%

                      │   old.txt   │              new.txt              │
                      │  allocs/op  │  allocs/op   vs base              │
Compilation/wazero-10   429.1k ± 0%   429.1k ± 0%       ~ (p=0.937 n=6)
Compilation/zig-10      269.7k ± 0%   269.6k ± 0%       ~ (p=1.000 n=6)
Compilation/zz-10       605.7k ± 0%   606.0k ± 0%       ~ (p=0.132 n=6)
geomean                 412.3k        412.4k       +0.02%

#2182

@mathetake mathetake merged commit c6ffc9e into main Jun 18, 2024
58 checks passed
@mathetake mathetake deleted the regalloc2222 branch June 18, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant