-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bench: add stdlib benchmark old vs new compiler #1878
Conversation
Signed-off-by: Edoardo Vacchi <[email protected]>
Signed-off-by: Edoardo Vacchi <[email protected]>
Signed-off-by: Edoardo Vacchi <[email protected]>
Signed-off-by: Edoardo Vacchi <[email protected]>
notice that currently, these aren't running on CI as the corresponding |
Signed-off-by: Edoardo Vacchi <[email protected]>
Signed-off-by: Edoardo Vacchi <[email protected]>
Signed-off-by: Edoardo Vacchi <[email protected]>
pushed a new version. It is likely to break due to old cache IDs. It is currently broken on Windows. My guess is because local, Windows-style paths are not compatible with the Unix-style wasm paths. e.g. |
Signed-off-by: Edoardo Vacchi <[email protected]>
7825a19
to
ebcfd9b
Compare
too many issues with paths to write one test case that works also on Windows, I'll return to this later; let's see if it works on CI this way for now:
|
Signed-off-by: Edoardo Vacchi <[email protected]>
I suspect the CygWin/MSYS shells on CI are masking a lot of path conversion issues that are explicit if we just run the cases using |
Signed-off-by: Edoardo Vacchi <[email protected]>
Signed-off-by: Edoardo Vacchi <[email protected]>
huh potential failure in src/reflect "due" to the perfmap feature, see https://github.com/tetratelabs/wazero/actions/runs/7267487881/job/19801438025?pr=1878 EDIT: oh it's just a nil pointer
|
Signed-off-by: Edoardo Vacchi <[email protected]>
I think this is the best I can do at this point. Unfortunately, CI on Windows has a lot of quirks, it's better just to run the CLI. |
redraft: maybe I found something... |
Signed-off-by: Edoardo Vacchi <[email protected]>
Signed-off-by: Edoardo Vacchi <[email protected]>
Signed-off-by: Edoardo Vacchi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Creating in draft for early feedback