Allow downstream projects to import func-e #446
Conversation
|
CI is failing due to an unrelated test failing func-e/lint/last_known_envoy_test.go Line 37 in 9c44e50 |
| // Wait for run to exit or an explicit stop. | ||
| select { | ||
| case <-ctx.Done(): | ||
| return nil |
There was a problem hiding this comment.
shouldn't we kill the envoy process in this case? (not sure if there's such function in func-e now)
There was a problem hiding this comment.
isn't this done in the called func libs
Line 78 in 82577c9
There was a problem hiding this comment.
ok cool but it seems to me that the code block only reaches when the OS signal was sent. Is there any way to verify that it works as intended? e.g. passing the fake config that runs indefinitely in tests?
There was a problem hiding this comment.
can you point me to some tests in the code base that verify this, that I can peruse here ?
There was a problem hiding this comment.
sorry no idea. Could you do that by yourself ?
* Define an api that allows go projects to use func-e as a library Takes #434 forward Fixes: #433 Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: Arko Dasgupta <[email protected]>
Takes #434 forward
Fixes: #433