Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move packages from /internal to /pkg #419

Closed
wants to merge 1 commit into from

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Dec 8, 2021

  • Allows external repositories to import func-e packages so that developers can leverage func-e to offload envoy binary arch type, version, download repository etc.
  • This allows the developer to import this go package to mimic func-e run w/o downloading
    envoy or func-e for quick prototyping and end to end testing.
  • More reuse, less code duplication :)
    Signed-off-by: Arko Dasgupta [email protected]

Allows external repositories to import these packages

Signed-off-by: Arko Dasgupta <[email protected]>
@arkodg arkodg marked this pull request as draft December 8, 2021 21:02
@codefromthecrypt
Copy link
Contributor

only a top-level interface and factory to implement it should be public. moving everything internal public impacts our ability to refactor anything

@codefromthecrypt
Copy link
Contributor

if we had an api, it would basically only expose the features the CLI can do and no more, and with the minimal types needed to do that.

ex. an interface FuncE with functions defined for Run, Use, etc with the same allowed arguments as the CLI. This would then also be consumed by the CLI and be available for embedding. I'm not sure the package named pkg is modern nowadays, and it is certainly vague. This interface could be in its own package like api.

@arkodg
Copy link
Contributor Author

arkodg commented Dec 9, 2021

thanks for the advice, will take another pass at only moving the minimum packages needed to call the func-e CLI in a programmatic way

@codefromthecrypt
Copy link
Contributor

I presume any change would be a different PR so I'll go ahead and close this to keep the queue clean. Take care!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants