Adds Windows Installer (MSI) to the release #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My approach to testing this will be to create a branch off this, remove the homebrew update, and do a dummy release of 0.6.1. If that works, I will delete the dummy release and we are all good! |
This adds func-e.msi manually until goreleaser/goreleaser#1295 This also adds basic testing of the msi as a part of e2e. Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
force-pushed
the
msi-release
branch
from
0817a30 to
f77067a
Compare
Signed-off-by: Adrian Cole <[email protected]>
|
current status 🤞 https://github.com/tetratelabs/func-e/runs/3258436193 |
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
|
That worked except a glitch as when verifying the install manually in windows, I noticed the control panel mentioned an incorrect version of func-e. fixed 3rd time's a charm https://github.com/tetratelabs/func-e/actions/runs/1103690668 |
Signed-off-by: Adrian Cole <[email protected]>
|
4th time was the charm https://github.com/tetratelabs/func-e/actions/runs/1103702795
known issue is that until #320 a blue warning and windows defender notices will happen on install |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds func-e.msi manually until goreleaser/goreleaser#1295
This also adds basic testing of the msi as a part of e2e.