-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial Review for Tethys 4.3 #1074
Conversation
bf23aa8
to
4fe3926
Compare
@swainn how do you access the docs build for a PR again? |
I'm confused about what is happening with the quotas tutorial. It looks like changes where made to the |
It's the details link next to the docs/readthedocs.org:tethys-platform check (near the bottom). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not allowed officially approve, since I have commits in this PR, but I approve.
@jakeymac please look into this. |
@sdc50 I've updated the tutorial. |
I rescind my previous rescinding. I now approve this PR. |
Description
This pull request include updates to all of the tutorials after a complete review. This update was necessary because of the changes to the app scaffold and other changes in Tethys 4.3. It also includes a few code changes that address issues discovered while reviewing the tutorials.
Changes Made to Code:
Quality Checks