Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial Review for Tethys 4.3 #1074

Merged
merged 28 commits into from
Aug 24, 2024
Merged

Tutorial Review for Tethys 4.3 #1074

merged 28 commits into from
Aug 24, 2024

Conversation

swainn
Copy link
Member

@swainn swainn commented Jul 29, 2024

Description

This pull request include updates to all of the tutorials after a complete review. This update was necessary because of the changes to the app scaffold and other changes in Tethys 4.3. It also includes a few code changes that address issues discovered while reviewing the tutorials.

Changes Made to Code:

  • All tutorials were reviewed and updated
  • Key Concepts tutorial was refactored to use the Map Layout instead of the Map View Gizmo for the primary map view. It still illustrates how to use the Map View Gizmo in forms.
  • Added screenshots to the Key Concepts tutorial to match the style of the newer tutorials.
  • Fixed a CSS issue in the app base template that prevented the Map View Gizmo from displaying when height was set to 100%.
  • Linted the default app scaffold template.
  • Fixed an issue with the map tabs content area on the Map Layout that was causing the page to have a scroll bar.

Quality Checks

  • [] New code is 100% tested
  • [] Code has been formatted
  • [] Code has been linted
  • [] Docstrings for new methods have been added

@coveralls
Copy link

coveralls commented Jul 29, 2024

Coverage Status

coverage: 99.936%. remained the same
when pulling d1757b9 on tutorial-review-43
into 1a761f2 on main.

@swainn swainn marked this pull request as ready for review August 17, 2024 00:32
@sdc50
Copy link
Member

sdc50 commented Aug 19, 2024

@swainn how do you access the docs build for a PR again?

@sdc50
Copy link
Member

sdc50 commented Aug 19, 2024

I'm confused about what is happening with the quotas tutorial. It looks like changes where made to the quotas-solution branch, that remove all of the code that the tutorial says to add.

@swainn
Copy link
Member Author

swainn commented Aug 19, 2024

@swainn how do you access the docs build for a PR again?

It's the details link next to the docs/readthedocs.org:tethys-platform check (near the bottom).

Copy link
Member Author

@swainn swainn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

docs/tutorials/geoserver/draw.rst Outdated Show resolved Hide resolved
docs/tutorials/google_earth_engine/part_1/gee_primer.rst Outdated Show resolved Hide resolved
docs/tutorials/google_earth_engine/part_2/file_upload.rst Outdated Show resolved Hide resolved
docs/tutorials/thredds/additional_exercises.rst Outdated Show resolved Hide resolved
docs/tutorials/websockets.rst Outdated Show resolved Hide resolved
docs/tutorials/dask/new_app_project.rst Outdated Show resolved Hide resolved
Copy link
Member Author

@swainn swainn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not allowed officially approve, since I have commits in this PR, but I approve.

@swainn
Copy link
Member Author

swainn commented Aug 22, 2024

I'm not allowed officially approve, since I have commits in this PR, but I approve.

I rescind my approval. I pulled up the check build of the docs and noticed that the logo looks terrible:

image

Remove the "Tethys Platform" text and use some custom CSS to make the logo bigger.

@swainn
Copy link
Member Author

swainn commented Aug 23, 2024

I'm confused about what is happening with the quotas tutorial. It looks like changes where made to the quotas-solution branch, that remove all of the code that the tutorial says to add.

@jakeymac please look into this.

@jakeymac
Copy link
Contributor

I'm confused about what is happening with the quotas tutorial. It looks like changes where made to the quotas-solution branch, that remove all of the code that the tutorial says to add.

@sdc50 I've updated the tutorial.

@swainn
Copy link
Member Author

swainn commented Aug 24, 2024

I'm not allowed officially approve, since I have commits in this PR, but I approve.

I rescind my approval. I pulled up the check build of the docs and noticed that the logo looks terrible:

image

Remove the "Tethys Platform" text and use some custom CSS to make the logo bigger.

I rescind my previous rescinding. I now approve this PR.

@swainn swainn merged commit be11028 into main Aug 24, 2024
42 checks passed
@swainn swainn deleted the tutorial-review-43 branch August 24, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment