-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Docker log tailing #1066
Fix Docker log tailing #1066
Conversation
Change the long-lived process from supervisord to tail, and prepend tail lines with the name of the file.
I made some 2 changes recommended by @araglu. I think the variable name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I just updated with some changes from main that should allow the docker build to go through and the docker startup test.
Hey @gronka I just tested this locally and I'm seeing a lot of these errors and no helpful logging:
Looks like some carriage return characters are causing issues maybe? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change from CRLF to LF line endings.
@swainn Thanks for figuring it out. I program in linux, so I don't know where an I don't have CRLF in my files, so I'm not sure how to proceed. I just deleted my repo and cloned it, and I still don't see any CLRF. Is this PR now a hidden branch in the tethysplatform repository? |
I usually add I think I was able to check out this PR branch with |
Hey I think I figured out what was going on. I built the Docker image for testing using Docker Desktop in Windows, so I bet the line endings go changed when I checked it out in windows. I just tested as-is in linux and it worked great. Sorry for the confusion. |
Change the long-lived process from supervisord to tail, and prepend tail lines with the name of the file.
Description
Fixes this issue:
#1048
Changes Made to Code:
Related
Additional Notes
tail
errors to/dev/null
Quality Checks