Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Channels Version for Django 3.2 builds #1058

Merged
merged 5 commits into from
Jun 7, 2024
Merged

Conversation

gagelarsen
Copy link
Contributor

@gagelarsen gagelarsen commented Jun 6, 2024

Description

This merge request addresses an issue where the Django 3.2 docker builds would overwrite the installed version of django because the used channels version would require Django >= 4.2.

Changes Made to Code:

  • Add a line to the Dockerbuild file that will check for django 3.2 and install an older version of channels.

Related

  • None

Additional Notes

  • This was found when trying to update the tethysext-atcore dockers.

Quality Checks

  • New code is 100% tested
  • Code has been formated
  • Code has been linted
  • Docstrings for new methods have been added

@gagelarsen gagelarsen requested a review from swainn June 6, 2024 16:49
@gagelarsen gagelarsen self-assigned this Jun 6, 2024
@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling bb3b498 on matrix_3.2_channels_fix
into 5dad136 on main.

@gagelarsen gagelarsen changed the title add line for django version 3.2 to install channels version WIP: Fix Channels Version for Django 3.2 builds Jun 6, 2024
@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling eb9fa57 on matrix_3.2_channels_fix
into 5dad136 on main.

@gagelarsen gagelarsen changed the title WIP: Fix Channels Version for Django 3.2 builds Fix Channels Version for Django 3.2 builds Jun 6, 2024
@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling a8af7e4 on matrix_3.2_channels_fix
into 5dad136 on main.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 5a2eab0 on matrix_3.2_channels_fix
into 5dad136 on main.

@swainn swainn requested review from sdc50 and shawncrawley June 6, 2024 21:32
@swainn
Copy link
Member

swainn commented Jun 6, 2024

Just need @sdc50 or @shawncrawley to review

Copy link
Contributor

@shawncrawley shawncrawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done.

@swainn swainn merged commit ab71fc5 into main Jun 7, 2024
42 checks passed
@swainn swainn deleted the matrix_3.2_channels_fix branch June 7, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants