Fix to issue 244 #253
Fix to issue 244 #253
Conversation
|
|
| @@ -1,8 +1,8 @@ | |||
| INSERT INTO `natural_text_actions` (`id`, `workspace_type`, `natural_text`, `data`, `display_name`, `snippet_class`, `action`, `created_date`, `updated_date`,`condition_type`, `allowed_values`, `import_to_web`, `import_to_mobile_web`, `import_to_android_native`, `import_to_ios_native`) VALUES | |||
There was a problem hiding this comment.
@creek23 You need to add update statements in a new migration file instead of changing the old migration files
There was a problem hiding this comment.
I'm preparing the SQL file with UPDATE statements which I believe can be used by existing install but I'd like to ask: Why not correct this file now -- why should we allow fresh installs to have this mistake?
There was a problem hiding this comment.
There are 2 scenarios here. For fresh install, your suggestion makes sense. But for migration from previous versions to the latest, the checksum for the migration files will fail. The migration files once applied will be stored in a db table with its calculated checksum. Once you change the file, the checksum wont match
There was a problem hiding this comment.
I don't know how Testsigma Server handles migration; for the "new migration file" you are asking, what filename should it be? -- I mean, how can Testsigma Server know that a new migration file is waiting to be triggered? Since it's modifying 2 separate tables, should it be 2 separate SQL files?
There was a problem hiding this comment.
@creek23 The filename can be anything as long as it follows the existing naming pattern. Testsigma tracks all the migration files it has applied till now in the table flyway_schema_history
| INSERT INTO `natural_text_action_examples` (`id`, `natural_text_action_id`, `description`, `example`, `workspace`, `data`, `created_date`, `updated_date`) VALUES (855,10209,'Store current Test Data Profile Name/Test Data Set Index/Test Data Set Name value into runtime varible','In this example, We will store the Test data profile related data into run time variable','https://app.testsigma.com/','{"attribute": "name", "test-data": "TestDataName"}','2021-12-23 17:34:05','2021-12-23 17:34:05'); | ||
| INSERT INTO `natural_text_action_examples` (`id`, `natural_text_action_id`, `description`, `example`, `workspace`, `data`, `created_date`, `updated_date`) VALUES (856,20163,'Store current Test Data Profile Name/Test Data Set Index/Test Data Set Name value into runtime varible','In this example, We will store the Test data profile related data into run time variable','https://app.testsigma.com/','{"attribute": "name", "test-data": "TestDataName"}','2021-12-23 17:34:05','2021-12-23 17:34:05'); | ||
| INSERT INTO `natural_text_action_examples` (`id`, `natural_text_action_id`, `description`, `example`, `workspace`, `data`, `created_date`, `updated_date`) VALUES (857,30192,'Store current Test Data Profile Name/Test Data Set Index/Test Data Set Name value into runtime varible','In this example, We will store the Test data profile related data into run time variable','https://app.testsigma.com/','{"attribute": "name", "test-data": "TestDataName"}','2021-12-23 17:34:05','2021-12-23 17:34:05'); | ||
| INSERT INTO `natural_text_action_examples` (`id`, `natural_text_action_id`, `description`, `example`, `workspace`, `data`, `created_date`, `updated_date`) VALUES (854,1095,'Store current Test Data Profile Name/Test Data Set Index/Test Data Set Name value into runtime variable','In this example, We will store the Test data profile related data into run time variable','https://app.testsigma.com/','{"attribute": "name", "test-data": "TestDataName"}','2021-12-23 17:34:05','2021-12-23 17:34:05'); |
There was a problem hiding this comment.
@creek23 Same as in above statement
Description
Updated misspelled
varibletovariableon SQL dumps from server's bootstrap and migration directory.This should fix the reported
Fixes #244
Checklist: