-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Ant #3071
Remove Ant #3071
Conversation
WalkthroughThis update primarily focuses on removing support for Apache Ant from the project, alongside updating version information formatting and fixing various issues including TestResult loss and race conditions. The removal of Ant support involves changes across multiple files, including the movement of Ant-related code to a separate repository and adjustments in build configurations to reflect this change. Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (4)
testng-ant/src/test/resources/ant/build-reporter-config.xml
is excluded by:!**/*.xml
testng-ant/src/test/resources/ant/build-simple.xml
is excluded by:!**/*.xml
testng-core/src/test/resources/testng.xml
is excluded by:!**/*.xml
testng-core/src/test/resources/testng.yaml
is excluded by:!**/*.yaml
Files selected for processing (4)
- CHANGES.txt (1 hunks)
- settings.gradle.kts (1 hunks)
- testng-bom/testng-bom-build.gradle.kts (1 hunks)
- testng/testng-build.gradle.kts (3 hunks)
Files not reviewed due to errors (1)
- TestNG_History_Log.txt (no review received)
Files skipped from review due to trivial changes (1)
- testng-bom/testng-bom-build.gradle.kts
Additional comments: 2
settings.gradle.kts (1)
- 18-23: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-30]
The removal of the
":testng-ant"
module fromsettings.gradle.kts
aligns with the PR's objective to decouple Ant support and migrate it to a separate repository. This change is straightforward and appears to be correctly implemented, ensuring that the":testng-ant"
module is no longer included in the project's build configuration.testng/testng-build.gradle.kts (1)
- 14-19: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-55]
The changes in
testng-build.gradle.kts
to remove Ant-related tasks and dependencies, including the removal of the "ant" task and references toorg.testng.internal.ant
, are in line with the PR's objectives. These modifications are expected to simplify the build process and reduce the project's dependency on Ant, aligning with the decision to migrate Ant support to a separate repository. It's important to ensure that these changes have been thoroughly tested to confirm that they do not negatively impact the build process or other functionalities.
This was truly hilarious and yet very very relevant. 😆 |
Moved to https://github.com/testng-team/testng-ant
Fixes #3033.
Did you remember to?
CHANGES.txt
./gradlew autostyleApply
Summary by CodeRabbit