-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use explicit dependency versions instead of refreshVersions #3068
Conversation
This improves support for Renovatebot and Dependabot
WalkthroughThis update focuses on enhancing library dependencies across various components of the project. Key updates include the advancement of the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (9)
- build-logic/code-quality/src/main/kotlin/testng.testing.gradle.kts (1 hunks)
- build.gradle.kts (1 hunks)
- settings.gradle.kts (1 hunks)
- testng-ant/testng-ant-build.gradle.kts (1 hunks)
- testng-core-api/testng-core-api-build.gradle.kts (1 hunks)
- testng-core/testng-core-build.gradle.kts (1 hunks)
- testng-runner-api/testng-runner-api-build.gradle.kts (1 hunks)
- testng-test-osgi/testng-test-osgi-build.gradle.kts (1 hunks)
- testng/testng-build.gradle.kts (1 hunks)
Files skipped from review due to trivial changes (2)
- build.gradle.kts
- settings.gradle.kts
Additional comments: 33
testng-runner-api/testng-runner-api-build.gradle.kts (1)
- 7-7: LGTM!
testng-ant/testng-ant-build.gradle.kts (2)
- 6-6: LGTM!
- 10-10: LGTM!
testng-core-api/testng-core-api-build.gradle.kts (4)
- 13-13: LGTM!
- 14-14: LGTM!
- 18-18: LGTM!
- 19-19: LGTM!
build-logic/code-quality/src/main/kotlin/testng.testing.gradle.kts (1)
- 9-9: LGTM!
testng-core/testng-core-build.gradle.kts (15)
- 32-32: LGTM!
- 33-33: LGTM!
- 35-35: LGTM!
- 37-37: LGTM!
- 42-42: LGTM!
- 44-44: LGTM!
- 47-47: LGTM!
- 48-48: LGTM!
- 49-49: LGTM!
- 50-50: LGTM!
- 51-51: LGTM!
- 52-52: LGTM!
- 53-53: LGTM!
- 54-54: LGTM!
- 55-55: LGTM!
testng/testng-build.gradle.kts (2)
- 21-21: LGTM!
- 25-25: LGTM!
testng-test-osgi/testng-test-osgi-build.gradle.kts (8)
- 21-21: LGTM!
- 25-25: LGTM!
- 28-28: LGTM!
- 29-29: LGTM!
- 30-30: LGTM!
- 31-31: LGTM!
- 32-32: LGTM!
- 33-33: LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think gradle plugins for dependency management are useless now?
And what do you think about the catalog?
As Dependabot / Renovatebot could create PRs, they are much better to maintain than manually creating PRs. Gradle plugins might be useful for in-house development, however, I do not see much value for public GitHub projects.
I have not tried it much. |
This improves support for Renovatebot and Dependabot
Summary by CodeRabbit