-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamline Logging Across TestNG #2646
Comments
Sure, I think slf4j is light enough to be added as a dependency. From the architecture pov, I think we should keep the current logger facade and call slf4j from there. |
@juherr - Cool. I will work on raising a PR that addresses this ask shortly |
TBD: how should be the verbose level managed? |
@juherr - I think we should think of deprecating the verbose attribute and just have it managed via the loggers verbosity. The other option would be to try and map a few of the initial values to the loggers verbosity (1 - error, 2 - warning) but I think that's going to be counter intuitive but will help us retain backward compatibility. |
I don't know if we can remove the verbose level because it could be used by default listeners. But I agree that the internal logger should not be impacted by this value (but it could be by the runner configuration). The level map will be necessary for the support of Reporter.log(). |
Closes testng-team#2646 We now use sl4j apis for our logging. Internally TestNG makes use of SimpleLogger (Slf4j-simple) bindings for logging purposes.
Closes testng-team#2646 We now use sl4j apis for our logging. Internally TestNG makes use of SimpleLogger (Slf4j-simple) bindings for logging purposes.
Closes testng-team#2646 We now use sl4j apis for our logging. Internally TestNG makes use of SimpleLogger (Slf4j-simple) bindings for logging purposes.
Closes testng-team#2646 We now use sl4j apis for our logging. Internally TestNG makes use of SimpleLogger (Slf4j-simple) bindings for logging purposes.
Closes testng-team#2646 We now use sl4j apis for our logging. Internally TestNG makes use of SimpleLogger (Slf4j-simple) bindings for logging purposes.
Closes testng-team#2646 We now use sl4j apis for our logging. Internally TestNG makes use of SimpleLogger (Slf4j-simple) bindings for logging purposes.
Closes #2646 We now use sl4j apis for our logging. Internally TestNG makes use of SimpleLogger (Slf4j-simple) bindings for logging purposes.
TestNG Version
7.4.0
Currently TestNG uses a mixture of sysouts and a custom logger that only logs to the console. We should enhance TestNG to use slf4j api integration so that our downstream consumers can basically work with their logging configurations and also help them streamline the test logs.
@juherr WDYT ?
The text was updated successfully, but these errors were encountered: