Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly invoke selenium.jar with -debug flag #35

Merged
merged 1 commit into from
Jun 28, 2017
Merged

fix: properly invoke selenium.jar with -debug flag #35

merged 1 commit into from
Jun 28, 2017

Conversation

dbushong
Copy link
Member

@dbushong dbushong commented Jun 27, 2017 •
edited
Loading

  • -debug now takes an argument
  • selenium.debug option should be getBool() to be false-able

Fixes #34

@dbushong
fix: properly invoke selenium.jar with -debug flag
76f1358 
* `-debug` now takes an argument
* `selenium.debug` option should be `getBool()` to be false-able
jkrems
jkrems approved these changes Jun 27, 2017
View reviewed changes
Copy link
Member

@jkrems jkrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dbushong dbushong merged commit a99bcfa into master Jun 28, 2017
@dbushong dbushong deleted the selenium-fixes branch June 28, 2017 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkrems jkrems jkrems approved these changes

Assignees
No one assigned
Labels
semver-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbushong @jkrems @i-tier-bot