Send headers to a page with hash segments #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (isNewPage(request.url)) { | ||
| modifyRequest(remoteRequestOptions, newPageOptions); | ||
| } | ||
| console.log(' %j', remoteRequestOptions); |
There was a problem hiding this comment.
Moved so the additional options are correctly logged. Makes finding issues like this much easier.
jkrems
force-pushed
the
jk-hash-and-headers
branch
from
ce6bf97 to
29201c6
Compare
|
Ran a decently sized test suite that uses hash urls & headers. It passes against |
|
Looks good. I guess we were just a little too hasty in the last PR. |
jkrems
added a commit
that referenced
this pull request
Oct 27, 2015
Send headers to a page with hash segments
|
v1.1.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the combinations of features.