Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(dom): Document breaking changes of v8 #866

Merged
merged 3 commits into from
Jun 23, 2021
Merged

docs(dom): Document breaking changes of v8 #866

merged 3 commits into from
Jun 23, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jun 20, 2021

@eps1lon eps1lon added the high priority 🔥 Most important label Jun 20, 2021
@eps1lon eps1lon mentioned this pull request Jun 20, 2021
Merged
7 tasks
kentcdodds
kentcdodds approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than one typo everything's great 👍

docs/dom-testing-library/api-async.mdx Outdated Show resolved Hide resolved
@eps1lon eps1lon requested a review from timdeschryver June 22, 2021 14:08
@eps1lon eps1lon merged commit ebb4a6b into testing-library:main Jun 23, 2021
@eps1lon eps1lon deleted the dom-alpha branch June 23, 2021 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdeschryver timdeschryver timdeschryver approved these changes

@kentcdodds kentcdodds kentcdodds approved these changes

@alexkrolick alexkrolick Awaiting requested review from alexkrolick

Assignees
No one assigned
Labels
high priority 🔥 Most important
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eps1lon @kentcdodds @timdeschryver