-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump kcd-scripts to 11.x #921
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d1c9869:
|
Codecov Report
@@ Coverage Diff @@
## main #921 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 140 140
Branches 28 28
=========================================
Hits 140 140 Continue to review full report at Codecov.
|
setImmediate(() => { | ||
Promise.resolve().then(() => { | ||
microTaskSpy() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setImmediate
is no longer available in jsdom
. Promise.resolve()
does the same thing considering the naming microTaskSpy
@@ -2,7 +2,7 @@ let act, asyncAct | |||
|
|||
beforeEach(() => { | |||
jest.resetModules() | |||
act = require('..').act | |||
act = require('../pure').act |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
..
would include automatic cleanup i.e. setting up beforeEach
and afterEach
hooks. This throws now in jest.
47db554
to
d1c9869
Compare
🎉 This PR is included in version 12.0.0-alpha.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 12.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Targetting
alpha
since@testing-library/dom@latest
is not compatible with jest 27What:
Update
npm run validate
dependenciesWhy:
To stay up-to-date with latest dependencies
How:
Bump
kcd-scripts
incrementally up until 11.x. Each commits bumps by a major so review by commit is advised.Checklist:
[ ]Documentation added to thedocs site
[ ]Typescript definitions updated