-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No type definitions for react/pure #695
Labels
Comments
kentcdodds
added a commit
that referenced
this issue
Jun 5, 2020
I think this should fix it: #696 Could you confirm? |
kentcdodds
added a commit
that referenced
this issue
Jun 5, 2020
* fix(TS): add type defs file for pure Closes #695 * Update pure.d.ts Co-authored-by: Andrei Picus <[email protected]> * Update package.json Co-authored-by: Andrei Picus <[email protected]>
🎉 This issue has been resolved in version 10.2.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Thanks @NiGhTTraX for catching this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@testing-library/react
version: 10.2.0Relevant code or config:
What happened:
Reproduction:
https://codesandbox.io/s/nifty-tharp-3de0h?file=/src/index.ts:61-114
Problem description:
This is happening because the
pure.d.ts
file is not next topure.js
, it's in atypes
folder and TS doesn't know how to link it. It's OK for the entry index because there's apkg.types
pointing to it, but importing something else requires the type file to be colocated.Suggested solution:
I think the files could either be moved next to their corresponding
.js
files and the build step updated to include them, or have a separate build step that doescp types/*.d.ts dist/
.The text was updated successfully, but these errors were encountered: