feat(cleanup): remove unnecessary flush microtasks as already handled by act

[mpeyper]

What:

Remove some particularly complicated code that flushes microtasks as part of cleaning up the rendered hooks.

Why:

I noticed this change in RTL from which we originally borrowed the flush-microtasks.js implementation from. The interesting part is that we already have our cleanup wrapped in act so the code was even less required.

How:

I deleted the file and removed the import and usage of it.

One difference to the RTL PR to note is that they also change cleanup from an async function to a regular function. I chose not to do this as we recently introduced the addCleanup functionality in v3.5.0 which allowed user provided cleanup to be async and I didn't want to restrict them to being sync only, plus it avoided a breaking change.

Checklist:

• Tests
• Ready to be merged
  

I wonder if this should go out into a beta release like they did in RTL or if their beta is proof that it's fine and we just release the minor?

[codecov]

Codecov Report

Merging #511 (c365fbb) into master (c7ee0b4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #511   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          128       127    -1     
  Branches        24        24           
=========================================
- Hits           128       127    -1     

Impacted Files	Coverage Δ
src/cleanup.js	100.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7ee0b4...c365fbb. Read the comment docs.

[joshuaellis]

When did they release this beta? Were there any issues open against it?

[mpeyper]

Beta was released on 30/8 and full release went out on 2/9.

I don't know if there were any issues raised, but there were no additional commits between bets and release.

[joshuaellis]

@mpeyper Can't see any issues relating to that release open or closed & the comments in the PR seem really positive. IMO we could just release this.

[mpeyper]

ok, here we go...

[github-actions]

🎉 This PR is included in version 3.7.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀