Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support RN 0.63 Pressable in toBeDisabled #33

Merged
merged 2 commits into from
Sep 7, 2020

Conversation

mateusbw
Copy link
Contributor

What:

Updated jest-native to support RN 0.63 Pressable component in toBeDisabled.

Why:

When testing a Pressable component the test always fails.

How:

Updated dependencies to support RN 0.63. Added Pressable to supported Types.

Checklist:

  • Documentation added to the
    docs (N/A)
  • Typescript definitions updated (N/A)
  • Tests
  • Ready to be merged

Related to issue #23

@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #33 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #33   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines           92        92           
  Branches        24        24           
=========================================
  Hits            92        92           
Impacted Files Coverage Δ
src/to-be-disabled.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c6659c...b4c73e2. Read the comment docs.

@brunohkbx brunohkbx linked an issue Aug 11, 2020 that may be closed by this pull request
@brunohkbx
Copy link
Collaborator

For further clarification, updating react-native to 0.63.2 doesn't break tests with TouchableHighlight and TouchableOpacity as described in #23 because @testing-library/react-native 6.0.0 is mocking them here

@brunohkbx brunohkbx merged commit 2649017 into testing-library:master Sep 7, 2020
@bcarroll22
Copy link
Collaborator

🎉 This PR is included in version 3.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants