fix: support TextInput editable={false} prop check in isEnabled/isDisabled matchers #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattAgn
reviewed
Dec 8, 2022
MattAgn
reviewed
Dec 8, 2022
MattAgn
reviewed
Dec 8, 2022
HugoChollet
force-pushed
the
feat/to-be-disabled-editable-prop
branch
from
42f9c49 to
0b3de92
Compare
Codecov Report
@@ Coverage Diff @@
## main #135 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 224 227 +3
Branches 70 71 +1
=========================================
+ Hits 224 227 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
HugoChollet
force-pushed
the
feat/to-be-disabled-editable-prop
branch
from
140494c to
efbfca6
Compare
mdjastrzebski
approved these changes
Dec 9, 2022
There was a problem hiding this comment.
Looks good, let's 🚢 it!
@HugoChollet congratulation on your first PR to Jest Native! 👏
mdjastrzebski
changed the title
|
🎉 This PR is included in version 5.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
toBeDisabledandtoBeEnabledmatcher will now look at theeditableprop from theTextInputcomponentWhy:
TextInputdoes not have adisabledprops but aeditableto enable or disable it. The only way to test if it is truly disabled is througheditableHow:
Added a supplementary check in
isElementDisabledfunctionChecklist: