.toHaveStyle() to support transform styles #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 92 94 +2
Branches 24 26 +2
=========================================
+ Hits 92 94 +2
Continue to review full report at Codecov.
|
|
Hi @philipbulley. Thank you for contributing. |
# Conflicts: # README.md # src/__tests__/to-have-style.js
brunohkbx
approved these changes
Sep 7, 2020
brunohkbx
added a commit
that referenced
this pull request
Sep 7, 2020
They are breaking in master for some unknown reason and we don't need them at all since we can assert the right behavior.
brunohkbx
added a commit
that referenced
this pull request
Sep 7, 2020
|
🎉 This PR is included in version 3.4.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
mateusbw
pushed a commit
to mateusbw/jest-native
that referenced
this pull request
Sep 8, 2020
* feat(toHaveStyle): Add ability to assert on transform styles * fix(docs): Change doc block lang to typescript to prevent prettier adding parens
mateusbw
pushed a commit
to mateusbw/jest-native
that referenced
this pull request
Sep 8, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Adds ability for
.toHaveStyle()to comparetransformstyles.Why:
Previously,
.toHaveStyle()would only operate on shallow style properties, but transforms are specified as anobject[]. The transform values would then be compared using strict equality and as such would never pass.Furthermore, the diffs would serialize the transform values as
[object Object]making both sides appear to be equal.Ultimately, the test would fail regardless but the diff would tell us that everything is fine.
How:
We're now properly handling any style properties with
object[]values and correctly serializing theexpectedandreceivedpassed tojestDiff. In both cases using recursion to perform the deep checks.Checklist:
docs
I noticed that up until now, there have been no snapshots assertions, but I've added two small snapshots of the
jestDiffoutput due to the added complexity in their generation. I think it's important to capture this — hope you don't mind.