-
Notifications
You must be signed in to change notification settings - Fork 44
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
They are breaking in master for some unknown reason and we don't need them at all since we can assert the right behavior.
- Loading branch information
Showing
2 changed files
with
2 additions
and
32 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -52,7 +52,7 @@ describe('.toHaveStyle', () => { | |
const container = getByTestId('container'); | ||
expect(() => | ||
expect(container).toHaveStyle({ backgroundColor: 'blue', transform: [{ scale: 1 }] }), | ||
).toThrowErrorMatchingSnapshot(); | ||
).toThrowError(); | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
brunohkbx
Author
Collaborator
|
||
expect(() => expect(container).toHaveStyle({ fontWeight: 'bold' })).toThrowError(); | ||
expect(() => expect(container).not.toHaveStyle({ color: 'black' })).toThrowError(); | ||
}); | ||
|
@@ -83,8 +83,6 @@ describe('.toHaveStyle', () => { | |
); | ||
|
||
const container = getByTestId('container'); | ||
expect(() => | ||
expect(container).toHaveStyle({ transform: [{ scale: 1 }] }), | ||
).toThrowErrorMatchingSnapshot(); | ||
expect(() => expect(container).toHaveStyle({ transform: [{ scale: 1 }] })).toThrowError(); | ||
}); | ||
}); |
Hi @brunohkbx, that's a shame that there's an unknown problem capturing snapshots on master. But I'm not sure I agree with your commit comment:
By removing this without providing an alternative, we've now lost the ability to test the diff output returned by
expectedDiff
which could now returnHello world!
and the tests would still pass. This is quite important functionality as it's key feedback users rely on when a test fails.