Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade jest-diff and jest-matcher-utils #63

Merged
merged 1 commit into from
Oct 6, 2018
Merged

fix: upgrade jest-diff and jest-matcher-utils #63

merged 1 commit into from
Oct 6, 2018

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Oct 6, 2018

What:

Upgrade dated dependencies.

Why:

Mostly to dedupe better on new projects, but it also brings in a bugfix (commented inline)

How:

npx npm-check-updates -u.

Checklist:

  • Documentation N/A
  • Tests N/A
  • Updated Type Definitions N/A
  • Ready to be merged
  • Added myself to contributors table

@@ -25,7 +25,6 @@ function printoutStyles(styles) {
.sort()
.map(prop => `${prop}: ${styles[prop]};`)
.join('\n')
.concat('\n') // ensure multiline for diff
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 23.0.0: jestjs/jest#6221

"pretty-format": "^23.0.1",
"jest-diff": "^23.6.0",
"jest-matcher-utils": "^23.6.0",
"pretty-format": "^23.6.0",
Copy link
Contributor Author

@SimenB SimenB Oct 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed as it's within semver range (and jest-diff depends on it), but doesn't hurt to keep them in sync

@smacpherson64 smacpherson64 merged commit af4c490 into testing-library:master Oct 6, 2018
@smacpherson64
Copy link
Collaborator

Awesome, Thank you!

@gnapse
Copy link
Member

gnapse commented Oct 6, 2018

🎉 This PR is included in version 2.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SimenB SimenB deleted the upgrade-deps branch October 6, 2018 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants