Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "build(deps-dev): bump prettier from 2.8.7 to 3.0.3 (#825)" #826

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

Belco90
Copy link
Member

@Belco90 Belco90 commented Oct 3, 2023

This reverts commit 9ef055d.

Checks

Changes

  • Reverting prettier v3 upgrade

Context

Prettier public API was changed to full async methods in v3, removing some sync methods we used. The PR for upgrading prettier to v3 got merged because the code validation checks weren't flagged as required (they are now). The auto-generator for docs was failing after upgrading to prettier v3, and we need some TS config changes to be able to switch to the new async prettier methods (because of top-level await basically).

I'm reverting prettier upgrade for now. In some follow-up PRs I'll upgrade TS to v5, then update the TS Config based on TotalTypeScript's TSConfig Cheat Sheet, and finally upgrade to prettier v3 again using the new async methods.

@Belco90 Belco90 self-assigned this Oct 3, 2023
@Belco90 Belco90 enabled auto-merge (squash) October 3, 2023 15:34
@Belco90 Belco90 disabled auto-merge October 3, 2023 15:44
@Belco90 Belco90 merged commit 7c44703 into main Oct 3, 2023
29 checks passed
@Belco90 Belco90 deleted the revert-825-dependabot/npm_and_yarn/prettier-3.0.3 branch October 3, 2023 15:44
@github-actions
Copy link

🎉 This PR is included in version 6.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant