Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(no-global-regexp-flag-in-query): enable by default #660

Merged
merged 1 commit into from
Oct 2, 2022
Merged

feat(no-global-regexp-flag-in-query): enable by default #660

merged 1 commit into from
Oct 2, 2022

Conversation

skovy
Copy link
Collaborator

@skovy skovy commented Oct 1, 2022

BREAKING CHANGE: enable no-global-regexp-flag-in-query for all shared configs by default

Checks

  • I have read the contributing guidelines.
  • If some rule is added/updated/removed, I've regenerated the rules list (npm run generate:rules-list)
  • If some rule meta info is changed, I've regenerated the plugin shared configs (npm run generate:configs)

Changes

  • Enable no-global-regexp-flag-in-query by default for all shared configs

Context

Resolves #618

@Belco90
Copy link
Member

Belco90 commented Oct 2, 2022

Can you resolve the conflicts? I'll merge it after that.

BREAKING CHANGE: enable no-global-regexp-flag-in-query for all libraries by default
@Belco90 Belco90 merged commit d0d0df5 into testing-library:alpha Oct 2, 2022
@skovy skovy deleted the pr/enable-no-global-regexp-flag-in-query branch October 2, 2022 18:50
@github-actions
Copy link

github-actions bot commented Oct 2, 2022

🎉 This PR is included in version 6.0.0-alpha.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MichaelDeBoey MichaelDeBoey added v6 Next major v6 BREAKING CHANGE This change will require a major version bump labels Oct 2, 2022
@MichaelDeBoey MichaelDeBoey linked an issue Oct 4, 2022 that may be closed by this pull request
MichaelDeBoey pushed a commit that referenced this pull request Oct 4, 2022
…660)

BREAKING CHANGE: `no-global-regexp-flag-in-query` is now enabled by default in all configs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This change will require a major version bump hacktoberfest-accepted released on @alpha v6 Next major v6
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Enable no-global-regexp-flag-in-query in all shareable configs
3 participants