Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove prefer-wait-for rule #627

Closed
Belco90 opened this issue Aug 4, 2022 · 2 comments · Fixed by #648
Closed

Remove prefer-wait-for rule #627

Belco90 opened this issue Aug 4, 2022 · 2 comments · Fixed by #648
Labels
BREAKING CHANGE This change will require a major version bump released on @alpha v6 Next major v6

Comments

@Belco90
Copy link
Member

Belco90 commented Aug 4, 2022

Remove prefer-wait-for rule, since wait, waitForElement and waitForDomChange have been removed already
@MichaelDeBoey MichaelDeBoey added the BREAKING CHANGE This change will require a major version bump label Aug 4, 2022
@Belco90 Belco90 added the v6 Next major v6 label Aug 4, 2022
@MichaelDeBoey MichaelDeBoey changed the title Remove prefer-wait-for rule Remove prefer-wait-for rule Aug 4, 2022
@skovy skovy mentioned this issue Sep 17, 2022
Merged
3 tasks
Belco90 pushed a commit that referenced this issue Sep 19, 2022
@skovy
feat: remove prefer-wait-for rule (#648)
5aa0194 
chore: remove prefer-wait-for rule

BREAKING CHANGE: remove prefer-wait-for rule

Closes #627
@github-actions
Copy link

🎉 This issue has been resolved in version 6.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Belco90 Belco90 closed this as completed Sep 19, 2022
Repository owner moved this from Todo to Done in eslint-plugin-testing-library v6 Sep 19, 2022
@Belco90
Copy link
Member Author

Belco90 commented Oct 21, 2022

I just realized there are other rules like prefer-find-by that are still checking these async methods. I'm going to add another ticket to check other places and remove such checks for removed async utils.

@Belco90 Belco90 mentioned this issue Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BREAKING CHANGE This change will require a major version bump released on @alpha v6 Next major v6
Projects
No open projects
eslint-plugin-testing-library v6
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: remove prefer-wait-for rule
2 participants
@Belco90 @MichaelDeBoey