Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for old node versions #616

Closed
Belco90 opened this issue Aug 4, 2022 · 5 comments · Fixed by #898 or #901
Closed

Drop support for old node versions #616

Belco90 opened this issue Aug 4, 2022 · 5 comments · Fixed by #898 or #901
Assignees
@Belco90
Labels
BREAKING CHANGE This change will require a major version bump released on @beta released v7 Next major v7

Comments

@Belco90
Copy link
Member

Belco90 commented Aug 4, 2022 •
edited
Loading

Drop support for node v12, which reaches EOL in 2022-04-30, and node v17, which reaches EOL in 2022-06-01

Update Node.js engine requirement to ^18.18.0 || >=20.0.0, which is the same requirement that ESLint v9 will impose. This means we are dropping support for Node 12, 15, 16, 17, 19, and Node 18 versions prior to 18.18.0.
@Belco90 Belco90 mentioned this issue Aug 4, 2022
Closed
14 tasks
@Belco90 Belco90 changed the title Drop support for node v12, which reaches EOL in 2022-04-30, and node v17, which reaches EOL in 2022-06-01 Drop support for old node versions Aug 4, 2022
@Belco90 Belco90 added the BREAKING CHANGE This change will require a major version bump label Aug 4, 2022
@MichaelDeBoey
Copy link
Member

We should wait & see what ESLint will be doing to get to the same minimal version imo

@Belco90 Belco90 added the v6 Next major v6 label Aug 4, 2022
@Belco90
Copy link
Member Author

Belco90 commented Aug 1, 2023

ESLint keeps supporting node v12, v14, v16 and greater. We can leave this for a future major then.

@Belco90 Belco90 added v6 Next major v6 v7 Next major v7 and removed v6 Next major v6 labels Jan 15, 2024
@Belco90
Copy link
Member Author

Belco90 commented Feb 25, 2024 •
edited
Loading

We should do the same as typescript-eslint v7 and update Node.js engine requirement to ^18.18.0 || >=20.0.0.

@Belco90 Belco90 moved this from Todo to In Progress in eslint-plugin-testing-library v7 Apr 16, 2024
@Belco90 Belco90 self-assigned this Apr 16, 2024
@Belco90 Belco90 mentioned this issue Apr 16, 2024
Merged
1 task
@Belco90 Belco90 linked a pull request Apr 16, 2024 that will close this issue
chore: drop support for old Node.js versions #898
Merged
1 task
Belco90 added a commit that referenced this issue Apr 17, 2024
@Belco90
chore: drop support for old Node.js versions (#898)
6e7ecdc 
BREAKING CHANGE: drop support for old Node.js versions

Closes #616
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 7.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Belco90 Belco90 mentioned this issue Apr 17, 2024
Merged
1 task
@Belco90 Belco90 moved this from In Progress to Done in eslint-plugin-testing-library v7 Apr 18, 2024
@Belco90 Belco90 mentioned this issue Oct 17, 2024
Merged
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Belco90 Belco90

Labels
BREAKING CHANGE This change will require a major version bump released on @beta released v7 Next major v7
Projects
eslint-plugin-testing-library v7
Status: Done
Milestone
No milestone
2 participants
@Belco90 @MichaelDeBoey