feat(no-manual-cleanup): add to React & Vue configs by default (#659)

BREAKING CHANGE: `no-manual-cleanup` is now enabled by default in the React & Vue configs
testing-library · Oct 4, 2022 · 8f6ebf5 · 8f6ebf5
1 parent 9acba43
commit 8f6ebf5
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -216,7 +216,7 @@ To enable this configuration use the `extends` property in your
 | [`no-debugging-utils`](./docs/rules/no-debugging-utils.md)                           | Disallow the use of debugging utilities like `debug`                                         |     | ![angular-badge][] ![react-badge][] ![vue-badge][] ![marko-badge][]                |
 | [`no-dom-import`](./docs/rules/no-dom-import.md)                                     | Disallow importing from DOM Testing Library                                                  | 🔧  | ![angular-badge][] ![react-badge][] ![vue-badge][] ![marko-badge][]                |
 | [`no-global-regexp-flag-in-query`](./docs/rules/no-global-regexp-flag-in-query.md)   | Disallow the use of the global RegExp flag (/g) in queries                                   | 🔧  |                                                                                    |
-| [`no-manual-cleanup`](./docs/rules/no-manual-cleanup.md)                             | Disallow the use of `cleanup`                                                                |     |                                                                                    |
+| [`no-manual-cleanup`](./docs/rules/no-manual-cleanup.md)                             | Disallow the use of `cleanup`                                                                |     | ![react-badge][] ![vue-badge][]                                                    |
 | [`no-node-access`](./docs/rules/no-node-access.md)                                   | Disallow direct Node access                                                                  |     | ![angular-badge][] ![react-badge][] ![vue-badge][] ![marko-badge][]                |
 | [`no-promise-in-fire-event`](./docs/rules/no-promise-in-fire-event.md)               | Disallow the use of promises passed to a `fireEvent` method                                  |     | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] ![marko-badge][] |
 | [`no-render-in-lifecycle`](./docs/rules/no-render-in-lifecycle.md)                   | Disallow the use of `render` in testing frameworks setup functions                           |     | ![angular-badge][] ![react-badge][] ![vue-badge][] ![marko-badge][]                |

diff --git a/lib/configs/react.ts b/lib/configs/react.ts
@@ -11,6 +11,7 @@ export = {
 		'testing-library/no-container': 'error',
 		'testing-library/no-debugging-utils': 'error',
 		'testing-library/no-dom-import': ['error', 'react'],
+		'testing-library/no-manual-cleanup': 'error',
 		'testing-library/no-node-access': 'error',
 		'testing-library/no-promise-in-fire-event': 'error',
 		'testing-library/no-render-in-lifecycle': 'error',

diff --git a/lib/configs/vue.ts b/lib/configs/vue.ts
@@ -12,6 +12,7 @@ export = {
 		'testing-library/no-container': 'error',
 		'testing-library/no-debugging-utils': 'error',
 		'testing-library/no-dom-import': ['error', 'vue'],
+		'testing-library/no-manual-cleanup': 'error',
 		'testing-library/no-node-access': 'error',
 		'testing-library/no-promise-in-fire-event': 'error',
 		'testing-library/no-render-in-lifecycle': 'error',

diff --git a/lib/rules/no-manual-cleanup.ts b/lib/rules/no-manual-cleanup.ts
@@ -28,8 +28,8 @@ export default createTestingLibraryRule<Options, MessageIds>({
 			recommendedConfig: {
 				dom: false,
 				angular: false,
-				react: false,
-				vue: false,
+				react: 'error',
+				vue: 'error',
 				marko: false,
 			},
 		},

diff --git a/tests/__snapshots__/index.test.ts.snap b/tests/__snapshots__/index.test.ts.snap
@@ -93,6 +93,7 @@ Object {
         "error",
         "react",
       ],
+      "testing-library/no-manual-cleanup": "error",
       "testing-library/no-node-access": "error",
       "testing-library/no-promise-in-fire-event": "error",
       "testing-library/no-render-in-lifecycle": "error",
@@ -123,6 +124,7 @@ Object {
         "error",
         "vue",
       ],
+      "testing-library/no-manual-cleanup": "error",
       "testing-library/no-node-access": "error",
       "testing-library/no-promise-in-fire-event": "error",
       "testing-library/no-render-in-lifecycle": "error",