Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support ESLint 7.x #46

Merged
merged 1 commit into from
Jun 11, 2020
Merged

feat: Support ESLint 7.x #46

merged 1 commit into from
Jun 11, 2020

Conversation

MichaelDeBoey
Copy link
Member

BREAKING CHANGE: Requires Node@^10.12.x || 12.x
BREAKING CHANGE: Requires ESLint@^7.x

Closes #45

@MichaelDeBoey MichaelDeBoey mentioned this pull request May 9, 2020
Merged
26 tasks
@benmonro
Copy link
Member

benmonro commented May 10, 2020 •
edited
Loading

Lgtm once the build is passing. Let me know if Travis is being a pain I've switched a lot of my projects to GitHub actions and been pretty happy. Wouldn't mind doing that here if Travis gets out of line

@MichaelDeBoey
Copy link
Member Author

@benmonro I think kcd-scripts can benefit from GitHub Actions eventually, but we're good for now with Travis 🙂

Will take a closer look on what's causing CI to fail

benmonro
benmonro reviewed May 12, 2020
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
benmonro
benmonro reviewed May 12, 2020
View reviewed changes
.travis.yml Show resolved Hide resolved
benmonro
benmonro requested changes May 12, 2020
View reviewed changes
Copy link
Member

@benmonro benmonro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the review change, but do we need the 12.0 in the travis.yml since we already have 12?

@MichaelDeBoey
feat: Support ESLint 7.x
6e0fecb 
BREAKING CHANGE: Requires Node@^10.12.x || 12.x
BREAKING CHANGE: Requires ESLint@^7.x
@codecov
Copy link

codecov bot commented Jun 10, 2020 •
edited
Loading

Codecov Report

Merging #46 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #46   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          129       129           
  Branches        18        18           
=========================================
  Hits           129       129

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 800c370...6e0fecb. Read the comment docs.

@MichaelDeBoey MichaelDeBoey requested a review from benmonro June 10, 2020 22:50
@benmonro benmonro merged commit 64c9226 into testing-library:master Jun 11, 2020
@benmonro
Copy link
Member

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MichaelDeBoey MichaelDeBoey deleted the eslint-7 branch June 11, 2020 14:50
@MichaelDeBoey MichaelDeBoey mentioned this pull request Jun 23, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

@benmonro benmonro benmonro approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support ESLint 7.x
3 participants
@MichaelDeBoey @benmonro @kentcdodds